Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7645#discussion_r35434667
--- Diff:
sql/core/src/main/scala/org/apache/spark/sql/execution/SparkStrategies.scala ---
@@ -91,6 +90,18 @@ private[sql] abstract class SparkStrategies extends
QueryPlanner[SparkPlan] {
condition.map(Filter(_,
broadcastHashJoin)).getOrElse(broadcastHashJoin) :: Nil
}
+ private[this] def isValidSort(
+ leftKeys: Seq[Expression],
+ rightKeys: Seq[Expression]): Boolean = {
+ !leftKeys.zip(rightKeys).exists { keys =>
--- End diff --
I find the double-negation here to be a bit confusing. Could we remove a
level of negation by using `forall` instead of `exists` and pushing the
negation down?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
