Github user MechCoder commented on a diff in the pull request:
https://github.com/apache/spark/pull/5748#discussion_r35437614
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/feature/Word2Vec.scala ---
@@ -431,36 +422,41 @@ class Word2Vec extends Serializable with Logging {
* Word2Vec model
*/
@Experimental
-class Word2VecModel private[spark] (
- model: Map[String, Array[Float]]) extends Serializable with Saveable {
-
- // wordList: Ordered list of words obtained from model.
- private val wordList: Array[String] = model.keys.toArray
+class Word2VecModel private[mllib] (
+ private val wordIndex: Map[String, Int],
+ private val wordVectors: Array[Float]) extends Serializable with
Saveable {
// wordIndex: Maps each word to an index, which can retrieve the
corresponding
// vector from wordVectors (see below).
- private val wordIndex: Map[String, Int] = wordList.zip(0 until
model.size).toMap
+ // wordVectors: Array of length numWords * vectorSize, vector
corresponding
--- End diff --
But this is not meant to be public at any point of time. Is that okay?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
