Github user feynmanliang commented on the pull request:
https://github.com/apache/spark/pull/7620#issuecomment-124709170
LGTM pending tests, we'll need @jkbradley to trigger the Jenkins build.
I would actually prefer that the two be in separate tests so it's easy to
identify which optimizer is failing by just looking at which test is failing. I
agree there is quite a bit of DRYing to do in `LDASuite`, but that can be
addressed in some follow up PRs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
