Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7535#discussion_r35485896
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/analysis/Analyzer.scala
---
@@ -910,6 +913,34 @@ class Analyzer(
Project(finalProjectList, withWindow)
}
}
+
+ /**
+ * Pulls out nondeterministic expressions from LogicalPlan which is not
Project or Filter,
+ * put them into an inner Project and finally project them away at the
outer Project.
+ */
+ object PullOutNondeterministic extends Rule[LogicalPlan] {
+ override def apply(plan: LogicalPlan): LogicalPlan = plan transform {
+ case p: Project => p
+ case f: Filter => f
+
+ // todo: It's hard to write a general rule to pull out
nondeterministic expressions
+ // from LogicalPlan, currently we only do it for UnaryNode which has
same output
+ // schema with its child.
+ case p: UnaryNode if p.output == p.child.output &&
p.expressions.exists(!_.deterministic) =>
--- End diff --
cc @marmbrus / @yhuai
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
