Github user cloud-fan commented on the pull request:
https://github.com/apache/spark/pull/7583#issuecomment-124942975
@yhuai sorry that I made a mistake at the beginning, actually
`retainGroupColumns` has no problem as we will alias literals in dataframe, and
literals in aggregation expressions are already allowed. Thus I think we can
safely remove literals in grouping expressions.
And I also make old and new aggregation code consistent about literals in
grouping here. In old aggregation, we'll remove literals from grouping but new
aggregation is not. So I explicitly make it a rule in Optimizer.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
