GitHub user viirya opened a pull request:
https://github.com/apache/spark/pull/7677
[SPARK-9361][SQL] Refactor new aggregation code to reduce the times of
checking compatibility
JIRA: https://issues.apache.org/jira/browse/SPARK-9361
Currently, we call `aggregate.Utils.tryConvert` in many places to check it
the logical.Aggregate can be run with new aggregation. But looks like
`aggregate.Utils.tryConvert` will cost considerable time to run. We should only
call `tryConvert` once and keep it value in `logical.Aggregate` and reuse it.
In `org.apache.spark.sql.execution.aggregate.Utils`, the codes involving
with `tryConvert` should be moved to catalyst because it actually doesn't deal
with execution details.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/viirya/spark-1 refactor_aggregate
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/spark/pull/7677.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #7677
----
commit 0a91329a1f3c84cf55cd3e44fc6148740c177195
Author: Liang-Chi Hsieh <[email protected]>
Date: 2015-07-26T16:48:58Z
Refactor new aggregation code to reduce the times to call tryConvert.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
