Github user rxin commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7674#discussion_r35495343
  
    --- Diff: sql/core/src/test/scala/org/apache/spark/sql/DataFrameSuite.scala 
---
    @@ -30,33 +30,28 @@ import org.apache.spark.sql.test.{ExamplePointUDT, 
ExamplePoint, SQLTestUtils}
     class DataFrameSuite extends QueryTest with SQLTestUtils {
       import org.apache.spark.sql.TestData._
     
    -  lazy val ctx = org.apache.spark.sql.test.TestSQLContext
    -  import ctx.implicits._
    -
    -  def sqlContext: SQLContext = ctx
    +  val sqlContext = org.apache.spark.sql.test.TestSQLContext
    --- End diff --
    
    lazy val here - otherwise a failure in the ctor could wipe out the entire 
test suite and then test cases won't show up as a failed tests.



---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to