Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/947#discussion_r13456581
--- Diff: core/src/main/scala/org/apache/spark/rdd/PairRDDFunctions.scala
---
@@ -755,7 +756,8 @@ class PairRDDFunctions[K, V](self: RDD[(K, V)])
logDebug("Saving as hadoop file of type (" + keyClass.getSimpleName +
", " +
valueClass.getSimpleName + ")")
- if (outputFormatInstance.isInstanceOf[FileOutputFormat[_, _]]) {
+ if (self.conf.getBoolean("spark.hadoop.validateOutputSpecs", true) &&
--- End diff --
Hey the fact that `self.conf` and `conf` have the same name is pretty bad
and it could easily lead to issues down the road. I realize it's not part of
your patch, but would you mind changing the input to be called `hadoopConf` so
that there is no overloading?
```
def saveAsNewAPIHadoopDataset(hadoopConf: Configuration) {
hadoopConf: JobConf = new JobConf(self.context.hadoopConfiguration),
```
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
