Github user srowen commented on the pull request:
https://github.com/apache/spark/pull/7559#issuecomment-125115185
No, that's not what I'm referring to. It is hacky to filter executors based
on numeric-or-not name but happens to work now. The problem is that most lines
of code in this PR have a problem -- you have a `var` where a `val` would do,
if you use collection mutation methods; there's an unnecessary getter; you're
using methods like `:+` with a `.`, unnecessary parens, missing whitespace,
etc.
I think it's best to close this PR and start over, since I don't think the
approach is right either. surely the problem, if there is one, is farther
upstream? why does the listener have `StorageStatus` for removed executors?
In the JIRA, can you propose any easy reproduction of this case?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
