Github user pwendell commented on a diff in the pull request:
https://github.com/apache/spark/pull/895#discussion_r13462856
--- Diff: docs/configuration.md ---
@@ -776,6 +776,34 @@ Apart from these, the following properties are also
available, and may be useful
higher memory usage in Spark.
</td>
</tr>
+<tr>
--- End diff --
It's a bit awkward here that you use the presence or absence of configs to
enabled different rolling strategies. What about something more explicit:
```
spark.executor.logs.rolling.enabled: true/[false]
spark.executor.logs.rolling.strategy: time/[size]
spark.executor.logs.rolling.time.interval: [daily]
spark.executor.logs.rolling.maxRetainedFiles: [none]
spark.executor.logs.rolling.size.maxBytes: [1024 * 1024]
```
My concern with the current approach is that when we add more options that
affect time-based rolling, it will be weird that the `interval` option happens
to enable time-based rolling. For instance, what if we add another option to
customize the date format.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
