Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/6986#discussion_r35581950
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/util/DateTimeUtils.scala
---
@@ -573,4 +573,48 @@ object DateTimeUtils {
dayInYear - 334
}
}
+
+ /**
+ * Returns Day of week from String. Starting from friday, marked as 0.
+ */
+ def getDayOfWeekFromString(string: UTF8String): Int = {
--- End diff --
Can you document inline why we choose Fri as 0, since it is a weird choice
(usually Sun or Mon is considered the beginning of the week). Is it because
1970-1-1 is a Thu?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
