Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/7410#discussion_r35610784
--- Diff:
external/kafka/src/main/scala/org/apache/spark/streaming/kafka/KafkaUtils.scala
---
@@ -684,3 +679,53 @@ private class KafkaUtilsPythonHelper {
kafkaRDD.offsetRanges.toSeq
}
}
+
+private object KafkaUtilsPythonHelper {
+ private var initialized = false
+
+ def initialize(): Unit = {
--- End diff --
Since `initialize()` is already called in `object KafkaUtilsPythonHelper`,
the purpose of adding the `initialize` method is only for loading the class of
`object KafkaUtilsPythonHelper`, right?
If changing it to
```
object KafkaUtilsPythonHelper {
SerDeUtil.initialize()
new PythonMessageAndMetadataPickler().register()
...
def createPicklerIterator: Iterator[Array[Byte]] = {
new SerDeUtil.AutoBatchedPickler(iter)
}
...
}
```
When calling KafkaUtilsPythonHelper.createPicklerIterator in the closure,
`SerDeUtil.initialize()` and `new PythonMessageAndMetadataPickler().register()`
will be called when loading class of `object KafkaUtilsPythonHelper`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
