Github user zsxwing commented on a diff in the pull request:
https://github.com/apache/spark/pull/7711#discussion_r35614391
--- Diff: dev/sparktestsupport/modules.py ---
@@ -126,15 +129,22 @@ def contains_file(self, filename):
)
+# Don't set the dependencies because changes in other modules should not
trigger Kinesis tests.
+# Kinesis tests depends on external Amazon kinesis service. We should run
these tests only when
+# files in streaming_kinesis_asl are changed, so that if Kinesis
experiences an outage, we don't
+# fail other PRs.
streaming_kinesis_asl = Module(
name="kinesis-asl",
- dependencies=[streaming],
+ dependencies=[],
source_file_regexes=[
"extras/kinesis-asl/",
],
build_profile_flags=[
"-Pkinesis-asl",
],
+ environs={
+ "ENABLE_KINESIS_TESTS": "1"
--- End diff --
@JoshRosen Kinesis unit tests will run when `ENABLE_KINESIS_TESTS` is `1`.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
