Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7682#discussion_r35616151
--- Diff:
sql/catalyst/src/main/java/org/apache/spark/sql/catalyst/expressions/UnsafeRow.java
---
@@ -236,6 +236,41 @@ public Object get(int ordinal) {
}
@Override
+ public Object get(int ordinal, DataType dataType) {
+ if (dataType instanceof NullType) {
--- End diff --
This reminds me: there's a potentially subtle pitfall with UnsafeRow if
someone calls a primitive type-specific accessor without first checking the
nullability: in that case, we'll currently return 0 instead of throwing an
error.
I'm going to add some assertions to try to see if there are any places
where we make this mistake.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
