Github user marmbrus commented on a diff in the pull request:

    https://github.com/apache/spark/pull/956#discussion_r13475392
  
    --- Diff: 
sql/hive/src/main/scala/org/apache/spark/sql/hive/HiveContext.scala ---
    @@ -129,7 +123,20 @@ class HiveContext(sc: SparkContext) extends 
SQLContext(sc) {
         }
       }
     
    +  /**
    +   * Any properties set by sqlConf.set() or a SET command inside hql() or 
sql()
    +   * will be set in the SQLConf, *as well as* getting set in the HiveConf. 
 In
    +   * other words, the SQLConf properties will be a subset of the HiveConf 
properties
    +   * throughout the life time of this session.
    +   */
       @transient protected[hive] lazy val hiveconf = new 
HiveConf(classOf[SessionState])
    +  @transient override lazy val sqlConf: SQLConf = new 
SQLConf(hiveconf.getAllProperties) {
    +    override def set(key: String, value: String): SQLConf = {
    +      runSqlHive(s"SET $key=$value")
    +      settings(key) = value
    --- End diff --
    
    I'd call `super.set(key, value)` instead here.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

Reply via email to