Github user dragos commented on the pull request:
https://github.com/apache/spark/pull/7600#issuecomment-125674890
@tdas I have some comments in my email that don't appear here, so I suppose
you changed your mind and deleted it.
I think the review would be smoother if you explained a bit better what are
your underlying concerns, rather than very specific points. For instance, I
don't understand why you insist I should avoid using your own helper methods. I
don't think code would get clearer, nor less flaky. If anything, reusing these
methods makes the code more uniform and easier to understand, plus any bugs
that get fixed in those helpers benefit this test suite too.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
