Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7644#discussion_r35674359
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/DateFunctionsSuite.scala ---
    @@ -206,4 +206,43 @@ class DateFunctionsSuite extends QueryTest {
           Seq(Row(Date.valueOf("2015-07-30")), 
Row(Date.valueOf("2015-07-30"))))
       }
     
    +  test("from_unixtime") {
    +    val sdf1 = new SimpleDateFormat("yyyy-MM-dd HH:mm:ss")
    +    val fmt2 = "yyyy-MM-dd HH:mm:ss.SSS"
    +    val sdf2 = new SimpleDateFormat(fmt2)
    +    val fmt3 = "yy-MM-dd HH-mm-ss"
    +    val sdf3 = new SimpleDateFormat(fmt3)
    +    val df = Seq((1000, "yyyy-MM-dd HH:mm:ss.SSS"), (-1000, "yy-MM-dd 
HH-mm-ss")).toDF("a", "b")
    +    checkAnswer(
    +      df.select(from_unixtime(col("a"))),
    +      Seq(Row(sdf1.format(new Timestamp(1000000))), Row(sdf1.format(new 
Timestamp(-1000000)))))
    +    checkAnswer(
    +      df.select(from_unixtime(col("a"), fmt2)),
    +      Seq(Row(sdf2.format(new Timestamp(1000000))), Row(sdf2.format(new 
Timestamp(-1000000)))))
    +    checkAnswer(
    +      df.select(from_unixtime(col("a"), fmt3)),
    +      Seq(Row(sdf3.format(new Timestamp(1000000))), Row(sdf3.format(new 
Timestamp(-1000000)))))
    --- End diff --
    
    Could we have a few test cases to test it as a function in SQL (using 
selectExpr())?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to