Github user davies commented on a diff in the pull request:

    https://github.com/apache/spark/pull/6988#discussion_r35703560
  
    --- Diff: 
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
 ---
    @@ -258,3 +258,70 @@ case class DateFormatClass(left: Expression, right: 
Expression) extends BinaryEx
         })
       }
     }
    +
    +/**
    + * Returns the date part of a timestamp string.
    + */
    +case class ToDate(child: Expression) extends UnaryExpression with 
ImplicitCastInputTypes {
    +
    +  override def inputTypes: Seq[AbstractDataType] = Seq(DateType)
    --- End diff --
    
    Could you add a comment says that this rely on implicit casting (from 
StringType and TimestampType)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to