Github user mengxr commented on the pull request:
https://github.com/apache/spark/pull/5909#issuecomment-125776127
@hhbyyh I made one pass:
1. We need unit tests.
2. There are couple ways to compute `Q`. For the first PR, I think we
should use the simplest approach: `Q = A * inv(R)`. It is not numerically
stable if `A` is ill-conditioned. But it is simple and works for most cases.
Preconditioning could come in a follow-up PR. So the final block of the PR
could be simplified.
I hope we can get this one in 1.5. Do you have time to address my comments
(before Thursday)? Or I can send you an update directly. Thanks!
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
