Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7705#discussion_r35726227
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAModel.scala ---
    @@ -287,15 +408,26 @@ class DistributedLDAModel private (
         private[clustering] val globalTopicTotals: LDA.TopicCounts,
         val k: Int,
         val vocabSize: Int,
    -    private[clustering] val docConcentration: Double,
    -    private[clustering] val topicConcentration: Double,
    +    protected[clustering] val docConcentration: Vector,
    --- End diff --
    
    For now, shall we add a check in the constructor to make sure 
docConcentration is valid (1 value, or k copies of the same value)?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to