Github user avulanov commented on the pull request:
https://github.com/apache/spark/pull/7621#issuecomment-125940544
@mengxr, thanks for the review! I've addressed everything, except I cannot
easily move everything to `spark.ml` since I am using `GradientDescent`
constructor which is `mllib` private (at the same time `LBFGS` is public).
Should we make it `spark` private? The other workaround would be to use
`GradientDescent.runMiniBatchSGD` and `LBFGS.runLBFGS` and switch between them
depending on the user input.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
