Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7432#discussion_r35788331
  
    --- Diff: 
mllib/src/test/scala/org/apache/spark/ml/classification/RandomForestClassifierSuite.scala
 ---
    @@ -167,7 +167,8 @@ private object RandomForestClassifierSuite {
         val newModel = rf.fit(newData)
         // Use parent from newTree since this is not checked anyways.
         val oldModelAsNew = RandomForestClassificationModel.fromOld(
    --- End diff --
    
    In one of these tests, can you please test to make sure the "rawPrediction" 
is consistent with the "prediction" column?  There may be code in other tests 
suites you can reuse.  Also, please test the value of numClasses stored in the 
model.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to