Github user jkbradley commented on a diff in the pull request:
https://github.com/apache/spark/pull/7705#discussion_r35794797
--- Diff:
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAModel.scala ---
@@ -287,15 +408,26 @@ class DistributedLDAModel private (
private[clustering] val globalTopicTotals: LDA.TopicCounts,
val k: Int,
val vocabSize: Int,
- private[clustering] val docConcentration: Double,
- private[clustering] val topicConcentration: Double,
+ protected[clustering] val docConcentration: Vector,
+ protected[clustering] val topicConcentration: Double,
+ protected[clustering] val gammaShape: Double,
private[spark] val iterationTimes: Array[Double]) extends LDAModel {
import LDA._
- private[clustering] def this(state: EMLDAOptimizer, iterationTimes:
Array[Double]) = {
- this(state.graph, state.globalTopicTotals, state.k, state.vocabSize,
state.docConcentration,
- state.topicConcentration, iterationTimes)
+ private[clustering] def this(
--- End diff --
That constructor has always been private API, so you do not need to
maintain it. Parts of MLlib which call it can simply use the new constructor.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
