Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7741#discussion_r35798092
--- Diff:
core/src/main/java/org/apache/spark/util/collection/unsafe/sort/UnsafeExternalSorter.java
---
@@ -147,9 +145,12 @@ public void spill() throws IOException {
}
private long getMemoryUsage() {
- return sorter.getMemoryUsage() + (allocatedPages.size() * (long)
PAGE_SIZE);
+ long totalPageSize = 0;
+ for (MemoryBlock page : allocatedPages) {
--- End diff --
This is only called when spilling and the corresponding methods in the
other classes are only called in debugging code which isn't called in normal
operation. Therefore, I'm not planning to change this in this patch.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
