Github user marmbrus commented on a diff in the pull request:
https://github.com/apache/spark/pull/7191#discussion_r35812315
--- Diff:
sql/hive-thriftserver/src/main/scala/org/apache/spark/sql/hive/thriftserver/SparkSQLSessionManager.scala
---
@@ -55,12 +56,14 @@ private[hive] class SparkSQLSessionManager(hiveContext:
HiveContext)
protocol: TProtocolVersion,
username: String,
passwd: String,
+ ipAddress: String,
sessionConf: java.util.Map[String, String],
withImpersonation: Boolean,
delegationToken: String): SessionHandle = {
hiveContext.openSession()
- val sessionHandle = super.openSession(
- protocol, username, passwd, sessionConf, withImpersonation,
delegationToken)
+ val sessionHandle = super
--- End diff --
Yeah I think technically the style guide says that once you wrap you must
wrap all of them. I'm not super strict about that one though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
