Github user zsxwing commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7774#discussion_r35837068
  
    --- Diff: 
sql/core/src/test/scala/org/apache/spark/sql/CachedTableSuite.scala ---
    @@ -305,12 +305,8 @@ class CachedTableSuite extends QueryTest {
         sql("SELECT key FROM testData LIMIT 10").registerTempTable("t1")
         sql("SELECT key FROM testData LIMIT 5").registerTempTable("t2")
     
    -    Accumulators.synchronized {
    -      val accsSize = Accumulators.originals.size
    -      ctx.cacheTable("t1")
    -      ctx.cacheTable("t2")
    -      assert((accsSize + 2) == Accumulators.originals.size)
    --- End diff --
    
    This assertion assumes there is only one `Accumulator` in `cacheTable`. But 
that's not true now.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to