Github user yjshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7779#discussion_r35840699
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -400,6 +400,31 @@ case class StringLocate(substr: Expression, str:
Expression, start: Expression)
}
}
+ override protected def genCode(ctx: CodeGenContext, ev:
GeneratedExpressionCode): String = {
+ val substrGen = substr.gen(ctx)
+ val strGen = str.gen(ctx)
+ val startGen = start.gen(ctx)
+ s"""
+ int ${ev.primitive} = 0;
+ boolean ${ev.isNull} = false;
--- End diff --
As @davies just commented on my code, it's better to make `${ev.isNull} =
true;` when expression take multiple expressions as input.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
