Github user squito commented on the pull request:

    https://github.com/apache/spark/pull/7753#issuecomment-126282507
  
    Since we'll eventually want to add more metrics, can you put all the netty 
metrics into another case class inside `ExecutorMetrics`?
    
    Also, I'm wondering if we want to use "netty" in the name -- I think most 
users won't know or care about netty in particular.  It should it just be named 
"network" or "transport", and the nio implementation should indicate that 
metrics are missing.
    
    I guess altogether this means doing something like:
    
    ```scala
    class ExecutorMetrics {
      var transportMetrics: Option[TransportMetrics] = ...
    }
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to