Github user srowen commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7142#discussion_r35896810
  
    --- Diff: docs/sql-programming-guide.md ---
    @@ -1890,10 +1890,10 @@ that these options will be deprecated in future 
release as more optimizations ar
       </tr>
       <tr>
         <td><code>spark.sql.codegen</code></td>
    -    <td>false</td>
    +    <td>true</td>
         <td>
           When true, code will be dynamically generated at runtime for 
expression evaluation in a specific
    -      query.  For some queries with complicated expression this option can 
lead to significant speed-ups.
    +      query. For some queries with complicated expression this option can 
lead to significant speed-ups.
           However, for simple queries this can actually slow down query 
execution.
    --- End diff --
    
    @davies which one is not needed -- 'this option can lead to significant 
speed-ups' or 'for simple queries this can actually slow down query execution'. 
Either way can you update it @KaiXinXiaoLei ?


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to