Github user shivaram commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7764#discussion_r35903215
  
    --- Diff: R/pkg/R/DataFrame.R ---
    @@ -1231,6 +1296,24 @@ setMethod("unionAll",
                 dataFrame(unioned)
               })
     
    +setGeneric("rbind", signature = "...")
    +
    +rbind.SparkDataFrames <- function(x, ..., deparse.level = 1) {
    +  allargs <- list(...)
    +  if (nargs() == 3) {
    +    unionAll(x, ...)
    +  } else {
    +    unionAll(x, Recall(..., deparse.level = 1))
    +  }
    +}
    +
    +#' @rdname rbind
    +#' @aliases unionAll
    +setMethod("rbind",
    +          signature(... = "DataFrame"),
    +          rbind.SparkDataFrames
    --- End diff --
    
    Its a good feature to have but I think its also fine to just support the 
two argument case if the other one adds too much complexity


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to