Github user jkbradley commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7801#discussion_r35918284
  
    --- Diff: 
mllib/src/main/scala/org/apache/spark/mllib/clustering/LDAModel.scala ---
    @@ -218,8 +218,16 @@ class LocalLDAModel private[clustering] (
         LocalLDAModel.SaveLoadV1_0.save(sc, path, topicsMatrix, 
docConcentration, topicConcentration,
           gammaShape)
       }
    -  // TODO
    -  // override def logLikelihood(documents: RDD[(Long, Vector)]): Double = 
???
    +
    +  // TODO: declare in LDAModel and override once implemented in 
DistributedLDAModel
    +  /**
    +   * Calculates an upper bound on the log likelihood of the entire corpus.
    --- End diff --
    
    This is a lower bound, not an upper bound, on the log likelihood.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to