Github user JoshRosen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7773#discussion_r35921016
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/plans/physical/partitioning.scala
---
@@ -122,7 +127,10 @@ case object SinglePartition extends Partitioning {
case _ => false
}
- override def keyExpressions: Seq[Expression] = Nil
+ override def guarantees(other: Partitioning): Boolean = other match {
--- End diff --
Shouldn't `SinglePartition` technically guarantee any partitioning which
produces a single partition, such as `HashPartitioning` with a single
partition? I guess that hash partitioning with one partition shouldn't ever
occur, though.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
