Github user marmbrus commented on the pull request:
https://github.com/apache/spark/pull/837#issuecomment-45418856
(I deleted my earlier comment because I found a mistake)
I think this is looking pretty good, but we should at least add one test
for the Broadcast Nested Loop version. Here's a PR against your branch that
does that: https://github.com/adrian-wang/spark/pull/1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
