Github user concretevitamin commented on the pull request:
https://github.com/apache/spark/pull/956#issuecomment-45419306
Regarding this particular question, I had a brief discussion with @rxin
before. We agreed that it seemed superfluous to only expose a setter
without exposing the getters and other methods. But if we went down that
route we might as well expose sqlConf since it only has a few methods.
What's your thoughts Michael?
On Saturday, June 7, 2014, Michael Armbrust <[email protected]>
wrote:
> This is looking pretty good. Thanks for working on it!
>
> I think the only remaining public interface question that I have is if we
> should expose the sqlConf to the user (i.e. sqlContext.sqlConf.set(...))
> or if we should just have methods directly on sqlContext (i.e.
> sqlContext.set(...)). Any thoughts @rxin <https://github.com/rxin>?
>
> â
> Reply to this email directly or view it on GitHub
> <https://github.com/apache/spark/pull/956#issuecomment-45419171>.
>
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
