Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7805#discussion_r35941764
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/datetimeFunctions.scala
---
@@ -696,3 +695,90 @@ case class MonthsBetween(date1: Expression, date2:
Expression)
})
}
}
+
+/**
+ * Returns the date part of a timestamp or string.
+ */
+case class ToDate(child: Expression) extends UnaryExpression with
ImplicitCastInputTypes {
+
+ // Implicit casting of spark will accept string in both date and
timestamp format, as
+ // well as TimestampType.
+ override def inputTypes: Seq[AbstractDataType] = Seq(DateType)
+
+ override def dataType: DataType = DateType
+
+ override def eval(input: InternalRow): Any = child.eval(input)
+
+ override def genCode(ctx: CodeGenContext, ev: GeneratedExpressionCode):
String = {
+ defineCodeGen(ctx, ev, d => d)
--- End diff --
tiny optimization - this can just call child.genCode
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
