Github user rxin commented on a diff in the pull request:
https://github.com/apache/spark/pull/7782#discussion_r35942465
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/stringOperations.scala
---
@@ -114,8 +114,32 @@ case class ConcatWs(children: Seq[Expression])
boolean ${ev.isNull} = ${ev.primitive} == null;
"""
} else {
- // Contains a mix of strings and array<string>s. Fall back to
interpreted mode for now.
- super.genCode(ctx, ev)
+ val list = ctx.freshName("list")
+ val array = ctx.freshName("array")
+ val sep = children.head.gen(ctx)
+ val argsCode = children.tail.map(x => {
+ val gen = x.gen(ctx)
+ if (x.dataType == StringType) {
+ s"""
+ ${gen.code}
+ $list.add(${gen.primitive});
+ """
+ } else {
+ s"""
+ ${gen.code}
+
$list.addAll(scala.collection.JavaConversions.asJavaCollection(${gen.primitive}));
--- End diff --
actually i think this breaks because now we refactored the codebase to use
ArrayData as the internal representation for Seq.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
