Github user rxin commented on the pull request:
https://github.com/apache/spark/pull/6519#issuecomment-126587929
@viirya I think the approach looks good now.
Can you add a lot more unit tests for both generated ordering and
interpreted ordering to make sure they work? I think the current code would
fail on nested structs.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
