Github user yjshen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7830#discussion_r35980080
--- Diff:
unsafe/src/main/java/org/apache/spark/unsafe/types/UTF8String.java ---
@@ -414,7 +413,7 @@ public int indexOf(UTF8String v, int start) {
*/
public UTF8String rpad(int len, UTF8String pad) {
int spaces = len - this.numChars(); // number of char need to pad
- if (spaces <= 0) {
+ if (spaces <= 0 || pad.numChars() == 0) {
// no padding at all, return the substring of the current string
return substring(0, len);
--- End diff --
@chenghao-intel and I think it's more proper to return the original string
when `pad` is an empty string. Hive didn't handle this situation and just hangs
forever.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
