Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7532#discussion_r35987260
  
    --- Diff: core/src/main/scala/org/apache/spark/deploy/master/Master.scala 
---
    @@ -563,32 +570,48 @@ private[master] class Master(
           app: ApplicationInfo,
           usableWorkers: Array[WorkerInfo],
           spreadOutApps: Boolean): Array[Int] = {
    -    // If the number of cores per executor is not specified, then we can 
just schedule
    -    // 1 core at a time since we expect a single executor to be launched 
on each worker
    -    val coresPerExecutor = app.desc.coresPerExecutor.getOrElse(1)
    +    val coresPerExecutor = app.desc.coresPerExecutor
    +    val minCoresPerExecutor = coresPerExecutor.getOrElse(1)
    --- End diff --
    
    hm, I thought we used `coresPerExecutor` down there, but maybe not in the 
latest code. If not we can merge these two.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to