Github user ilganeli commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7514#discussion_r36017849
  
    --- Diff: 
sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/commands.scala
 ---
    @@ -244,34 +244,65 @@ private[sql] case class InsertIntoHadoopFsRelation(
         }
     
         def writeRows(taskContext: TaskContext, iterator: 
Iterator[InternalRow]): Unit = {
    +      // Track which rows have been output to disk so that if a data sort 
is necessary mid-write,
    +      // we don't end up outputting the same data twice
    +      val writtenRows: HashSet[InternalRow] = new HashSet[InternalRow]
    --- End diff --
    
    Got it, so just use an ``ExternalSorter``` based off that iterator to do 
the sort to avoid potential memory problems.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to