Github user mengxr commented on a diff in the pull request:
https://github.com/apache/spark/pull/7818#discussion_r36024385
--- Diff: mllib/src/main/scala/org/apache/spark/mllib/fpm/PrefixSpan.scala
---
@@ -216,9 +223,12 @@ class PrefixSpan private (
val extendedPrefixAndSuffix = prefixSuffixPairs
.filter(x => prefixToNextItems.contains(x._1))
.flatMap { case (prefix, suffix) =>
- val frequentNextItems = prefixToNextItems(prefix)
- val filteredSuffix = suffix.filter(frequentNextItems.contains(_))
- frequentNextItems.flatMap { item =>
+ val frequentNextItemSets = prefixToNextItems(prefix)
+ val frequentNextItems = frequentNextItemSets.flatten
+ val filteredSuffix = suffix
+ .map(item => frequentNextItems.intersect(item))
+ .filterNot(_.isEmpty)
--- End diff --
nit: `filter(_.nonEmpty)` reads better to me
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
