Github user andrewor14 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/7820#discussion_r36031707
  
    --- Diff: 
core/src/main/scala/org/apache/spark/scheduler/cluster/mesos/CoarseMesosSchedulerBackend.scala
 ---
    @@ -261,7 +269,27 @@ private[spark] class CoarseMesosSchedulerBackend(
         val taskId = status.getTaskId.getValue.toInt
         val state = status.getState
         logInfo(s"Mesos task $taskId is now $state")
    +    val slaveId: String = status.getSlaveId.getValue
         stateLock.synchronized {
    +      if (TaskState.fromMesos(state).equals(TaskState.RUNNING) &&
    --- End diff --
    
    this block of code needs a huge comment:
    ```
    // If the shuffle service is enabled, have the driver register with each one
    // of them. This is important for cleaning up state on the shuffle services
    // after this application exits; there is currently not a great way to 
detect
    // this through Mesos, since the shuffle services are set up independently.
    ```


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to