Github user ash211 commented on a diff in the pull request:

    https://github.com/apache/spark/pull/369#discussion_r13530130
  
    --- Diff: core/src/main/scala/org/apache/spark/rdd/RDD.scala ---
    @@ -423,6 +423,18 @@ abstract class RDD[T: ClassTag](
       def ++(other: RDD[T]): RDD[T] = this.union(other)
     
       /**
    +   * Return this RDD sorted by the given key function.
    +   */
    +  def sortBy[K](
    +      f: (T) ⇒ K,
    +      ascending: Boolean = true,
    +      numPartitions: Int = this.partitions.size)
    +      (implicit ord: Ordering[K], ctag: ClassTag[K]): RDD[T] =
    --- End diff --
    
    Do we need to further discuss the way the parameter is passed or is the 
current method sufficient?  I'm not sure the implications for binary 
compatibility in the future if we switch between the two (context bound vs 
implicits).


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastruct...@apache.org or file a JIRA ticket
with INFRA.
---

Reply via email to