Github user cloud-fan commented on a diff in the pull request:
https://github.com/apache/spark/pull/7752#discussion_r36034378
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/codegen/GenerateUnsafeProjection.scala
---
@@ -250,6 +258,252 @@ object GenerateUnsafeProjection extends
CodeGenerator[Seq[Expression], UnsafePro
GeneratedExpressionCode(code, isNull, primitive)
}
+ /**
+ * Generates the Java code to convert a struct (backed by InternalRow)
to UnsafeRow.
+ *
+ * @param ctx code generation context
+ * @param inputs could be the codes for expressions or input struct
fields.
+ * @param inputTypes types of the inputs
+ */
+ private def createCodeForStruct2(
--- End diff --
This method covers both `createCodeForStruct` and `createCode`(they are not
needed any more). However, I still keep that 2 methods to avoid making code
review harder.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
