Github user srowen commented on a diff in the pull request:
https://github.com/apache/spark/pull/7846#discussion_r36037022
--- Diff:
yarn/src/main/scala/org/apache/spark/scheduler/cluster/YarnClientSchedulerBackend.scala
---
@@ -131,24 +131,35 @@ private[spark] class YarnClientSchedulerBackend(
}
}
+ private class MonitorThread extends Thread {
+ private var doInterrupt = true
+
+ override def run() {
+ try {
+ val (state, _) = client.monitorApplication(appId,
logApplicationReport = false)
+ logError(s"Yarn application has already exited with state $state!")
+ doInterrupt = false
+ sc.stop()
+ } catch {
+ case e: InterruptedException => logInfo("Interrupting monitor
thread")
+ }
+ }
+
+ def stopMonitor(): Unit = {
+ if (doInterrupt) {
+ this.interrupt()
+ }
+ }
+ }
+
/**
* Monitor the application state in a separate thread.
* If the application has exited for any reason, stop the SparkContext.
* This assumes both `client` and `appId` have already been set.
*/
- private def asyncMonitorApplication(): Thread = {
+ private def asyncMonitorApplication(): MonitorThread = {
assert(client != null && appId != null, "Application has not been
submitted yet!")
- val t = new Thread {
- override def run() {
- try {
- val (state, _) = client.monitorApplication(appId,
logApplicationReport = false)
- logError(s"Yarn application has already exited with state
$state!")
- sc.stop()
- } catch {
- case e: InterruptedException => logInfo("Interrupting monitor
thread")
- }
- }
- }
+ val t = new MonitorThread
--- End diff --
Yeah I think that's tidier. Now that it's its own named class, name and
daemon status can be set by the class itself I think.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
