Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/7279#discussion_r36038829
--- Diff: core/src/test/scala/org/apache/spark/ContextCleanerSuite.scala ---
@@ -221,23 +221,26 @@ class ContextCleanerSuite extends
ContextCleanerSuiteBase {
var rddId = rdd.id
// Confirm the checkpoint directory exists
- assert(RDDCheckpointData.rddCheckpointDataPath(sc, rddId).isDefined)
- val path = RDDCheckpointData.rddCheckpointDataPath(sc, rddId).get
+ assert(ReliableRDDCheckpointData.checkpointPath(sc, rddId).isDefined)
+ val path = ReliableRDDCheckpointData.checkpointPath(sc, rddId).get
val fs = path.getFileSystem(sc.hadoopConfiguration)
assert(fs.exists(path))
// the checkpoint is not cleaned by default (without the configuration
set)
- var postGCTester = new CleanerTester(sc, Seq(rddId), Nil, Nil, Nil)
+ var postGCTester = new CleanerTester(sc, Seq(rddId), Nil, Nil,
Seq(rddId))
rdd = null // Make RDD out of scope, ok if collected earlier
runGC()
postGCTester.assertCleanup()
- assert(fs.exists(RDDCheckpointData.rddCheckpointDataPath(sc,
rddId).get))
+ assert(!fs.exists(ReliableRDDCheckpointData.checkpointPath(sc,
rddId).get))
--- End diff --
Aah, you reverse the test, first test with checkpoint cleaning enabled (as
it was added to global conf), then test without checkpoint cleaning enabled.
But why? Why was the global conf changed?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
