Github user tdas commented on a diff in the pull request:
https://github.com/apache/spark/pull/7279#discussion_r36039679
--- Diff:
core/src/test/scala/org/apache/spark/rdd/LocalCheckpointSuite.scala ---
@@ -0,0 +1,330 @@
+/*
+ * Licensed to the Apache Software Foundation (ASF) under one or more
+ * contributor license agreements. See the NOTICE file distributed with
+ * this work for additional information regarding copyright ownership.
+ * The ASF licenses this file to You under the Apache License, Version 2.0
+ * (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software
+ * distributed under the License is distributed on an "AS IS" BASIS,
+ * WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+ * See the License for the specific language governing permissions and
+ * limitations under the License.
+ */
+
+package org.apache.spark.rdd
+
+import org.apache.spark.{SparkException, SparkContext, LocalSparkContext,
SparkFunSuite}
+
+import org.mockito.Mockito.spy
+import org.apache.spark.storage.{RDDBlockId, StorageLevel}
+
+/**
+ * Fine-grained tests for local checkpointing.
+ * For end-to-end tests, see CheckpointSuite.
+ */
+class LocalCheckpointSuite extends SparkFunSuite with LocalSparkContext {
+
+ override def beforeEach(): Unit = {
+ sc = new SparkContext("local[2]", "test")
+ }
+
+ test("transform storage level") {
+ val transform = LocalRDDCheckpointData.transformStorageLevel _
+ assert(transform(StorageLevel.NONE) === StorageLevel.DISK_ONLY)
+ assert(transform(StorageLevel.MEMORY_ONLY) ===
StorageLevel.MEMORY_AND_DISK)
+ assert(transform(StorageLevel.MEMORY_ONLY_SER) ===
StorageLevel.MEMORY_AND_DISK_SER)
+ assert(transform(StorageLevel.MEMORY_ONLY_2) ===
StorageLevel.MEMORY_AND_DISK_2)
+ assert(transform(StorageLevel.MEMORY_ONLY_SER_2) ===
StorageLevel.MEMORY_AND_DISK_SER_2)
+ assert(transform(StorageLevel.DISK_ONLY) === StorageLevel.DISK_ONLY)
+ assert(transform(StorageLevel.DISK_ONLY_2) ===
StorageLevel.DISK_ONLY_2)
+ assert(transform(StorageLevel.MEMORY_AND_DISK) ===
StorageLevel.MEMORY_AND_DISK)
+ assert(transform(StorageLevel.MEMORY_AND_DISK_SER) ===
StorageLevel.MEMORY_AND_DISK_SER)
+ assert(transform(StorageLevel.MEMORY_AND_DISK_2) ===
StorageLevel.MEMORY_AND_DISK_2)
+ assert(transform(StorageLevel.MEMORY_AND_DISK_SER_2) ===
StorageLevel.MEMORY_AND_DISK_SER_2)
+ // Off-heap is not supported and Spark should fail fast
+ intercept[SparkException] {
+ transform(StorageLevel.OFF_HEAP)
+ }
+ }
+
+ test("basic lineage truncation") {
+ val numPartitions = 4
+ val parallelRdd = sc.parallelize(1 to 100, numPartitions)
+ val mappedRdd = parallelRdd.map { i => i + 1 }
+ val filteredRdd = mappedRdd.filter { i => i % 2 == 0 }
+ val expectedPartitionIndices = (0 until numPartitions).toArray
+ assert(filteredRdd.checkpointData.isEmpty)
+ assert(filteredRdd.getStorageLevel === StorageLevel.NONE)
+ assert(filteredRdd.partitions.map(_.index) ===
expectedPartitionIndices)
+ assert(filteredRdd.dependencies.size === 1)
+ assert(filteredRdd.dependencies.head.rdd === mappedRdd)
+ assert(mappedRdd.dependencies.size === 1)
+ assert(mappedRdd.dependencies.head.rdd === parallelRdd)
+ assert(parallelRdd.dependencies.size === 0)
+
+ // Mark the RDD for local checkpointing
+ filteredRdd.localCheckpoint()
+ assert(filteredRdd.checkpointData.isDefined)
+ assert(!filteredRdd.checkpointData.get.isCheckpointed)
+ assert(!filteredRdd.checkpointData.get.checkpointRDD.isDefined)
+ assert(filteredRdd.getStorageLevel ===
LocalRDDCheckpointData.DEFAULT_STORAGE_LEVEL)
+
+ // After an action, the lineage is truncated
+ val result = filteredRdd.collect()
+ assert(filteredRdd.checkpointData.get.isCheckpointed)
+ assert(filteredRdd.checkpointData.get.checkpointRDD.isDefined)
+ val checkpointRdd =
filteredRdd.checkpointData.flatMap(_.checkpointRDD).get
+ assert(filteredRdd.dependencies.size === 1)
+ assert(filteredRdd.dependencies.head.rdd === checkpointRdd)
+ assert(filteredRdd.partitions.map(_.index) ===
expectedPartitionIndices)
+ assert(checkpointRdd.partitions.map(_.index) ===
expectedPartitionIndices)
+
+ // Recomputation should yield the same result
+ assert(filteredRdd.collect() === result)
+ assert(filteredRdd.collect() === result)
+ }
+
+ test("basic lineage truncation - caching before checkpointing") {
+ testBasicLineageTruncationWithCaching(
+ newRdd.persist(StorageLevel.MEMORY_ONLY).localCheckpoint(),
+ StorageLevel.MEMORY_AND_DISK)
+ }
+
+ test("basic lineage truncation - caching after checkpointing") {
+ testBasicLineageTruncationWithCaching(
+ newRdd.localCheckpoint().persist(StorageLevel.MEMORY_ONLY),
+ StorageLevel.MEMORY_AND_DISK)
+ }
+
+ test("indirect lineage truncation") {
+ testIndirectLineageTruncation(
+ newRdd.localCheckpoint(),
+ LocalRDDCheckpointData.DEFAULT_STORAGE_LEVEL)
+ }
+
+ test("indirect lineage truncation - caching before checkpointing") {
+ testIndirectLineageTruncation(
+ newRdd.persist(StorageLevel.MEMORY_ONLY).localCheckpoint(),
+ StorageLevel.MEMORY_AND_DISK)
+ }
+
+ test("indirect lineage truncation - caching after checkpointing") {
+ testIndirectLineageTruncation(
+ newRdd.localCheckpoint().persist(StorageLevel.MEMORY_ONLY),
+ StorageLevel.MEMORY_AND_DISK)
+ }
+
+ test("checkpoint without draining iterator") {
+ testWithoutDrainingIterator(
+ newSortedRdd.localCheckpoint(),
+ LocalRDDCheckpointData.DEFAULT_STORAGE_LEVEL,
+ 50)
+ }
+
+ test("checkpoint without draining iterator - caching before
checkpointing") {
+ testWithoutDrainingIterator(
+ newSortedRdd.persist(StorageLevel.MEMORY_ONLY).localCheckpoint(),
+ StorageLevel.MEMORY_AND_DISK,
+ 50)
+ }
+
+ test("checkpoint without draining iterator - caching after
checkpointing") {
+ testWithoutDrainingIterator(
+ newSortedRdd.localCheckpoint().persist(StorageLevel.MEMORY_ONLY),
+ StorageLevel.MEMORY_AND_DISK,
+ 50)
+ }
+
+ test("checkpoint blocks exist") {
+ testCheckpointBlocksExist(
+ newRdd.localCheckpoint(),
+ LocalRDDCheckpointData.DEFAULT_STORAGE_LEVEL)
+ }
+
+ test("checkpoint blocks exist - caching before checkpointing") {
+ testCheckpointBlocksExist(
+ newRdd.persist(StorageLevel.MEMORY_ONLY).localCheckpoint(),
+ StorageLevel.MEMORY_AND_DISK)
+ }
+
+ test("checkpoint blocks exist - caching after checkpointing") {
+ testCheckpointBlocksExist(
+ newRdd.localCheckpoint().persist(StorageLevel.MEMORY_ONLY),
+ StorageLevel.MEMORY_AND_DISK)
+ }
+
+ test("missing checkpoint block fails with informative message") {
+ val rdd = newRdd.localCheckpoint()
+ val numPartitions = rdd.partitions.size
+ val partitionIndices = rdd.partitions.map(_.index)
+ val bmm = sc.env.blockManager.master
+
+ // After an action, the blocks should be found somewhere in the cache
+ rdd.collect()
+ partitionIndices.foreach { i =>
+ assert(bmm.contains(RDDBlockId(rdd.id, i)))
+ }
+
+ // Remove one of the blocks to simulate executor failure
+ // Collecting the RDD should now fail with an informative exception
+ val blockId = RDDBlockId(rdd.id, numPartitions - 1)
+ bmm.removeBlock(blockId)
+ try {
+ rdd.collect()
+ fail("Collect should have failed if local checkpoint block is
removed...")
--- End diff --
```
val exception = intercept[SparkException] {
....
}
```
:)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
