Github user davies commented on a diff in the pull request:
https://github.com/apache/spark/pull/7580#discussion_r36039702
--- Diff:
sql/catalyst/src/main/scala/org/apache/spark/sql/catalyst/expressions/collectionOperations.scala
---
@@ -35,3 +37,62 @@ case class Size(child: Expression) extends
UnaryExpression with ExpectsInputType
nullSafeCodeGen(ctx, ev, c => s"${ev.primitive} = ($c).size();")
}
}
+
+case class ArrayContains(left: Expression, right: Expression)
+ extends BinaryExpression with ExpectsInputTypes {
+
+ override def dataType: DataType = BooleanType
+
+ override def inputTypes: Seq[AbstractDataType] = right.dataType match {
+ case NullType => Seq()
+ case _ => left.dataType match {
+ case n @ ArrayType(element, _) => Seq(n, element)
+ case _ => Seq()
+ }
+ }
+
+ override def checkInputDataTypes(): TypeCheckResult = {
+ inputTypes.size match {
+ case 0 => TypeCheckResult.TypeCheckFailure("Null typed values cannot
be used as arguments")
+ case _ => super.checkInputDataTypes()
+ }
+ }
+
+ override def nullable: Boolean = false
+
+ override def eval(input: InternalRow): Boolean = {
+ val arr = left.eval(input)
+ if (arr == null) {
+ false
+ } else {
+ val value = right.eval(input)
+ if (value == null) {
+ false
+ } else {
+ arr.asInstanceOf[Seq[Any]].contains(value)
+ }
+ }
+ }
+
+ override def genCode(ctx: CodeGenContext, ev: GeneratedExpressionCode):
String = {
+ val arrGen = left.gen(ctx)
+ val elementGen = right.gen(ctx)
+ s"""
+ ${arrGen.code}
+ boolean ${ev.isNull} = false;
+ boolean ${ev.primitive} = false;
+ if (${arrGen.isNull}) {
+ ${ev.primitive} = false;
--- End diff --
it's already false
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
