Github user feynmanliang commented on the pull request:

    https://github.com/apache/spark/pull/7869#issuecomment-127048275
  
    LGTM
    
    Only thought is perhaps making Scala API consistent with Java by also 
accepting an `Iterable[Iterable[Item]]`; since we will convert to `Array[Int]` 
internally anyways the conversion overhead will be inevitable.


---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---

---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to