Github user yjshen commented on the pull request:
https://github.com/apache/spark/pull/7855#issuecomment-127088391
All bugs revealed until now:
1. `UnaryMinus`'s codegen version would fail to compile when the input is
`Long.MinValue`
2. `Remainder` would fail due to codegen and interpret mode returning
different result for same input. (yes, for remainding between giant values)
3. `BinaryComparison` would fail to compile in codegen mode when comparing
Boolean types.
4. `AddMonth` would fail if passed a huge negative month, which would lead
accessing negative index of `monthDays` array.
And I also fixed `Nanvl` by upcasting its operand if the are of different
type.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at [email protected] or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
